Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The accuracy-comparison pipeline currently lacks a short offline numerical smoke test. Add four cases in
src/tests/test_accuracy_comparison_smoke.pythat run the existing comparison entry point with native Basilisk propagation for 600 seconds and check an independent closed-form circular-orbit reference.Temporary CSV files fill the GMAT/Orekit input slots, with manifests explicitly identifying them as synthetic analytic fixtures, not outputs from those tools. Cases cover both slots, Orekit-only selection, reporting deliberately offset states, and rejecting timestamp misalignment. Position and velocity tolerances are 1 cm and 0.1 mm/s. Existing platform CI collects the file automatically; no workflow or dependency changes are needed.
Verification
python -m pytest src/tests/test_accuracy_comparison_smoke.py -q: 4 passed in 2.30 s.Local checks used macOS arm64, Python 3.12, NumPy 2.3.5, and the official Basilisk 2.12.0 native wheel with the current source comparison scripts. The wider comparison run had 32 passes and one existing failure:
test_orekit_only_selection_needs_no_gmat_datarequiresExponentialAtmosphere.setPlanetPolarRadius, which is absent from that native wheel. The failure also reproduces when the existing test runs alone. It was deselected for the metadata-only run. A native build of current develop and the full project suite remain unverified, so this PR is a draft pending that validation.Documentation
The new file documents its fixture provenance and invocation. No production comparison case data, reference results, or API documentation change. Test-only maintenance is exempt from the release-note snippet requirement.
Future work
Validate against a native build of current develop and run the full project suite before marking ready for review.